From ee3bb1cd6e5eb5b1334c0c0b729e58b3d84c1d1b Mon Sep 17 00:00:00 2001
From: Khafid Prayoga <khafidp@pm.me>
Date: Fri, 29 Aug 2025 11:02:31 +0700
Subject: [PATCH] refactor(error): move error types to centralized location

Consolidate XError, XErrors, and FormErrors types into a single file for better maintainability and consistency across the codebase.
---
 app/components/app/divison/entry-form.vue |  2 +-
 app/composables/useFormErrors.ts          | 10 +--------
 app/composables/useXfetch.ts              | 10 +--------
 app/types/error.ts                        | 27 +++++++++++++++++++++++
 4 files changed, 30 insertions(+), 19 deletions(-)
 create mode 100644 app/types/error.ts

diff --git a/app/components/app/divison/entry-form.vue b/app/components/app/divison/entry-form.vue
index 4057cc53..348f440e 100644
--- a/app/components/app/divison/entry-form.vue
+++ b/app/components/app/divison/entry-form.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import type { FormErrors } from '~/composables/useFormErrors'
+import type { FormErrors } from '~/types/error'
 import Block from '~/components/pub/custom-ui/form/block.vue'
 import Combobox from '~/components/pub/custom-ui/form/combobox.vue'
 import FieldGroup from '~/components/pub/custom-ui/form/field-group.vue'
diff --git a/app/composables/useFormErrors.ts b/app/composables/useFormErrors.ts
index 03c95e97..2907540f 100644
--- a/app/composables/useFormErrors.ts
+++ b/app/composables/useFormErrors.ts
@@ -1,13 +1,5 @@
 import type { ZodError } from 'zod'
-
-export interface XError {
-  message: string
-  [key: string]: any
-}
-
-export interface FormErrors {
-  [field: string]: XError
-}
+import type { FormErrors } from '~/types/error'
 
 /**
  * Composable untuk menangani form validation errors seperti Laravel
diff --git a/app/composables/useXfetch.ts b/app/composables/useXfetch.ts
index 3f27c07f..87d69f97 100644
--- a/app/composables/useXfetch.ts
+++ b/app/composables/useXfetch.ts
@@ -1,13 +1,5 @@
 import type { Pinia } from 'pinia'
-
-export interface XError {
-  code: string
-  message: string
-  expectedVal?: string
-  givenVal?: string
-}
-
-export type XErrors = Record<string, XError>
+import type { XError, XErrors } from '~/types/error'
 
 export interface XfetchResult {
   success: boolean
diff --git a/app/types/error.ts b/app/types/error.ts
new file mode 100644
index 00000000..e1405b0d
--- /dev/null
+++ b/app/types/error.ts
@@ -0,0 +1,27 @@
+/**
+ * Base interface untuk error yang digunakan di seluruh aplikasi
+ */
+export interface XError {
+  /** Pesan error yang akan ditampilkan */
+  message: string
+  /** Kode error (opsional) */
+  code?: string
+  /** Nilai yang diharapkan (untuk validasi) */
+  expectedVal?: string
+  /** Nilai yang diberikan (untuk validasi) */
+  givenVal?: string
+  /** Path field yang error (untuk form validation) */
+  path?: (string | number)[]
+  /** Properties tambahan lainnya */
+  [key: string]: any
+}
+
+/**
+ * Collection of errors dengan key sebagai field name
+ */
+export type XErrors = Record<string, XError>
+
+/**
+ * Form errors type alias untuk kompatibilitas
+ */
+export type FormErrors = XErrors